search

stickbreaker / arduino-esp32

Arduino core for the ESP32
38 stars 23 forks source link

compiler error fix #29

Closed Yoshi20 closed 6 years ago

Yoshi20 commented 6 years ago

My compiler seems to be configured more critical than yours. Got some errors after forking and testing your repository. Luckily they can be fixed quite easily.

Thanks for your work.

By the way: Is there a date on which your i2c fixes will be merged into the https://github.com/espressif/arduino-esp32?

Keep it comming.

stickbreaker commented 6 years ago

@Yoshi20 me-no-dev is actively working to merge this branch with the main at espressif/arduino. My plan is to delete this branch after he completes the merge. I will continue to work on Slave mode and MultiMaster after the merge is complete. He is massively changing the flavor of my coding style. His changes will probably fix the errors you have detected.

Also, I would not accept the SD_MMC fix. My branch is only for i2c stuff. do a pull request at espressif/arduino for this fix. If I applied it to my branch, it would not help anyone, everyone just used the 5 i2c files from this branch.

It should only be a few days before my code is merged into espressif/arduino. I'm closing/refusing this pr.

me-no-dev commented 6 years ago

init bug is present only when using as idf component. The stickbreaker-i2c branch of the main repo ha s the MMC fixed and this I2C. You can use that branch while the update is being prepared :)

@stickbreaker my intention is to leave the comments in the hal driver, so you could continue work after the merge ;) I'll give you permissions to the main repo so you can use your own branch for I2C stuff :)

stickbreaker commented 6 years ago

thanks