search

stickermule / rump

Hot sync two Redis servers using dumps.
MIT License
491 stars 94 forks source link

Add progress bar (pb library) #1

Closed jdorfman closed 7 years ago

jdorfman commented 7 years ago

I believe that adding the pb library will help rump's UX

BDQ commented 7 years ago

@jdorfman I think that depends on knowing how much work we have to do or how long it might take, right I think we're just showing that it's doing something, not that we're x% complete.

jdorfman commented 7 years ago

@BDQ feel free to mark wontfix and close it.

adnanh commented 7 years ago

Maybe instead implement progress report on USR1 signal (if OS supports it) like the dd does?

nixtrace commented 7 years ago

Yeah, I thought about showing the progress at first.

The problem is that one of the core ideas of Rump is scanning, so it can't know the total number of keys to be transferred when it starts transferring.

It scans over the keys in batches and transfers a batch.

That's the reason why the tool is currently outputting > and ..

A > means a batch of keys has been read from source, and a . means a batch of keys has been restored on destination.

Maybe we can think about a more expressive symbol/word to show for a batch of keys dumped/restored.