sticks-stuff / highlight-RMS-supporters

GNU General Public License v3.0
40 stars 14 forks source link

Redesign #56

Closed nagatsu-chan closed 3 years ago

nagatsu-chan commented 3 years ago

This PR redesigns the script to be more memory efficient, plus to calm down the people saying that this violates GDPR. After this update, we do the following:

  1. Every hour the script makes a request to the RMS support signature repo
  2. The script parses the data and stores it in an IndexedDB
  3. The script finds users who match usernames in the IndexedDB, and highlights them in red.

Note that the parsing step only happens every hour, but step 3 happens any time the page updates (on github). This technique is significantly less memory intensive, as explained by #53

The parsing step is quite memory expensive, but it should only last a few seconds, and memory usage will return to normal after its complete.

As for GDPR, the script no longer needs to store a copy of peoples usernames on the github repo. The script now gets the usernames directly from the support letter repo. We are allowed to do this because the data is licensed under GPL. The old technique was also GDPR compliant, but this will hopefully help the people saying it isn't sleep at night

sticks-stuff commented 3 years ago

Thank you so much!! styles.css will be kept for the next couple days for backwards compatibility reasons but I'll remove it in the following days

Aspie96 commented 3 years ago

The old technique was also GDPR compliant,

Did you actually ever even read the GDPR?