sticks-stuff / highlight-RMS-supporters

GNU General Public License v3.0
40 stars 14 forks source link

Add a static list of GitHub usernames for the RMS supporters who linked to a non-GitHub site. #58

Open kakafarm opened 3 years ago

kakafarm commented 3 years ago

The RMS support letter does not currently support multiple addresses, so I had to choose my GitLab account (https://github.com/yuvallangerontheroad/rms-support-letter.github.io/blob/d91e98aa23ae0b43316f0c1eafb21d0b865a33c3/_data/signed/yuvallanger.yaml#L2), but on GitHub I use this account (https://github.com/yuvallangerontheroad/), and also https://github.com/yuvallanger/.

Could you add these accounts for me as a static list of GitHub usernames, as well for others in the future who wish to add themselves but do not have a github account displayed in the RMS support letter?

Thank you!

sticks-stuff commented 3 years ago

This can likely be accomplished by scraping the contributors of the repo viat the API (provided they added their signature via a GitHub PR) and then using that to fill in the gaps of any missing usernames. I'll look into it

kakafarm commented 3 years ago

This can likely be accomplished by scraping the contributors of the repo viat the API (provided they added their signature via a GitHub PR) and then using that to fill in the gaps of any missing usernames. I'll look into it

Using the API would not suffice as, for example, my https://github.com/yuvallanger/ account did not submit anything to the RMS support repository.

sticks-stuff commented 3 years ago

This might be too much of an edge case to solve, I’m open to suggestions or PRs however