search

stiftelsen-effekt / main-site

Repo for Gi Effektivt website front-end
https://www.gieffektivt.no
MIT License
4 stars 6 forks source link

Attempt dynamic page imports #960

Open adamalfredsson opened 7 months ago

adamalfredsson commented 7 months ago

Tested on devices

Tests

Checkpoints

Check these to flag for a more thurough review, as they could be potentially breaking changes

⏲️ Time spent on CR:

⏲️ Time spent on QA:

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ge-effektivt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 1:48pm
main-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 1:48pm
cypress[bot] commented 7 months ago

9 failed tests on run #2570 ↗︎

9 46 1 0 Flakiness 0

Details:

Fix type error
Project: Main site Commit: d14d148807
Status: Failed Duration: 01:07 💡
Started: Apr 12, 2024 1:49 PM Ended: Apr 12, 2024 1:50 PM
Failed  cypress/e2e/wealthcalculator.js • 9 failed tests • GiEffektivt e2e tests View Output Video
Test Artifacts
Navigation > Should initialize correctly Screenshots Video
Navigation > Should update graph when income is changed Screenshots Video
Navigation > Should update graph when children is changed Screenshots Video
Navigation > Should update graph when adults is changed Screenshots Video
Navigation > Should update graph when percentage is changed Screenshots Video
Navigation > Should allow users to slide the percentage slider Screenshots Video
Navigation > Should allow users to tap the slider track to change percentage Screenshots Video
Navigation > Should be possible to expand and collapse the explanation Screenshots Video
Navigation > Should be possible to click the create agreement button to open the widget Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

adamalfredsson commented 7 months ago

I believe this should solve it, but I'm not sure how to verify. Perhaps you could take a look, @fellmirr ? :)

fellmirr commented 7 months ago

Yes, I remember I tried something similar now that I see it!

Unfortunately the bundler seems to still be confused by this. I checked using the bundle analyser. https://nextjs.org/docs/app/building-your-application/optimizing/bundle-analyzer

image
fellmirr commented 7 months ago

(as an aside, some of these modules are really not needed in any case, like moment and validator, but that's for a separate issue (edit: added them in #965 and #964 ))