stig / ox-jira.el

Org-mode export backend for JIRA markup
131 stars 20 forks source link

Add ability to name src blocks and auto-collapse code blocks. #31

Closed rymndhng closed 7 years ago

rymndhng commented 7 years ago

Solves #30

stig commented 7 years ago

Hello, thank you for your PR! I like it! (I'm afraid I totally missed the notification about this, so sorry for the wait.) That said, I've got a couple comments / questions:

  1. Where did you find out about the collapse option? It's not listed here: https://jira.atlassian.com/secure/WikiRendererHelpAction.jspa?section=advanced -- is it available in all versions of JIRA?

  2. It feels like you should be using #+CAPTION: rather than #+NAME: as per http://orgmode.org/manual/Images-and-tables.html#Images-and-tables

rymndhng commented 7 years ago

Where did you find out about the collapse option? It's not listed here: https://jira.atlassian.com/secure/WikiRendererHelpAction.jspa?section=advanced -- is it available in all versions of JIRA?

I actually found this using the confluence code block macro (the doc site is down right now...). I did test it on JIRA and it worked as well.

It feels like you should be using #+CAPTION: rather than #+NAME: as per http://orgmode.org/manual/Images-and-tables.html#Images-and-tables

Sounds right -- Will update the PR

rymndhng commented 7 years ago

@stig I've updated the PR. Not sure if I have the best implementation for building the caption text (it came back as a sequence of characters).

rymndhng commented 7 years ago

@stig I've updated the PR.

stig commented 7 years ago

Thank you!