search

stigbjorlykke / rpm-spec-mode

RPM spec file editing commands for Emacs/XEmacs
GNU General Public License v2.0
12 stars 23 forks source link

Faces could use standard names #5

Open shaleh opened 10 years ago

shaleh commented 10 years ago

Instead of hard coding blue and red the standard names such as 'font-line-variable-name-face' could be used. This way rpm-spec-mode instantly meshes with the user's chosen theme without needing its own customization (or at least not too much).

Just setting these went a long way towards it fitting in with solarized.

'(rpm-spec-doc-face ((t (:inherit font-lock-doc-face))))
'(rpm-spec-var-face ((t (:inherit font-lock-variable-name-face))))
'(rpm-spec-tag-face ((t (:inherit font-lock-keyword-face))))

Are you open to discussing this? If so once there is consensus I would be happy to submit a patch or pull request.

birkenfeld commented 8 years ago

Seconded!

shaleh commented 8 years ago

Thank you @birkenfeld for reminding me of this. I just opened PR #10.

shaleh commented 8 years ago

Discussion about what I chose to map the names to are welcomed. The mapping was somewhat arbitrary.

shaleh commented 8 years ago

Also, I do not have XEmacs handy. If anyone could let me know if I broke something there I'd appreciate it.