stigbjorlykke / rpm-spec-mode

RPM spec file editing commands for Emacs/XEmacs
GNU General Public License v2.0
11 stars 22 forks source link

Add basic Imenu support for easy navigation. #8

Open carltonf opened 9 years ago

omajid commented 7 years ago

Some version of this would be great to have. Navigation by sections just makes so much sense in longer spec files. I have an alternate implementation at https://github.com/omajid/rpm-spec-mode/commit/dde79cd4b87a6fcdf602bdc82351d8d187e2a03d.

Thaodan commented 1 year ago

The PR uses (easy-menu-add) however it is obsolete since Emacs 28.1 and doesn't do anything.

See their note:

This function is obsolete since 28.1; this was always a no-op in Emacs and can be safely removed.

Thaodan commented 1 year ago

The patch also uses (add-to-list) for rpm-imenu-index however this doesn't work.

See Emacs output here:

lib/rpm-spec-mode/rpm-spec-mode.el:682:8: Error: ‘add-to-list’ can’t use lexical var ‘rpm-imenu-index’; use ‘push’ or ‘cl-pushnew’
Thaodan commented 1 year ago

See here for fixes for those issues: https://github.com/Thaodan/rpm-spec-mode/tree/add-imenu-support-fixes