stijn-volckaert / udemo

Demo Manager for Unreal Tournament
7 stars 2 forks source link

Hud Messages with empty line between #149

Closed prom6 closed 1 year ago

prom6 commented 1 year ago

Normally they should all come after each other, line by line. (its not everytime but frequently)

image

SeriousBuggie commented 1 year ago

Please post demo (with all related files), on which such happen.

prom6 commented 1 year ago

Here you go. Couldnt find AnthCheckerCv131 in my files (probably somewhere in cache but not listed in the .ini). I downloded the .uz file and put it in the package, hope thats ok. [[fd[-u-]]CTF-IncineratorLE-102[10_01_20062018][-u-]-morp.zip](https://github.com/stijn-volckaert/udemo/files/12506396/fd_.-u-._CTF-IncineratorLE-102_.10_01_2006_2018._.-u-.-morp.zip)

SeriousBuggie commented 1 year ago

This happen because of UTPure PureHitSound message. It is fake message, which produce hit sound on client side.

I found there problems with play such hit sounds. Which manage to fix it. Possible it make difference of handle messages for warm up flags. However, this not remove empty line.

I even not sure if this empty line not appear in real play. Did it appear in real gameplay?

prom6 commented 1 year ago

Well the demo is quite old, I'm not 100 percent sure, but I would think this displayed correctly when I played back then. Also its Pure7G and I have several demos with Pure7G where the messages are displayed correctly (hitsounds were enabled on all of them) I can search for a demo that is Pure7G with hitsounds but the messages displaying correctly if that helps?

SeriousBuggie commented 1 year ago

Yea. Possible it helps.

prom6 commented 1 year ago

Mh sorry I could have sworn its not on all demos, checked like 10 different ones from 2006 to 2010, all of them had it, just didnt notice before o_O But I'm still pretty sure it didnt display like that when I played on the server back then. But when it has something to do with hitsounds, wouldnt the empty line show up more frequently? Or has the hit to be at a certain time to mess up the messages?

SeriousBuggie commented 1 year ago

It show each time when hit sound appear. But you see it only if there be message before and after.

I found fix which allow show more messages, and actually play this hit sound (as for now it not play).

Unfortunately I can't apply some dirty hack which filter this messages out, since it not only stop hit sound here, but can stop it in more fresh NewNet, which now work properly.

prom6 commented 1 year ago

For me the hitsounds are working when playing the demo:

https://github.com/stijn-volckaert/udemo/assets/71797130/d52141f2-f2aa-4075-a4a5-9b757f2b7a16

if you got a fix but dont want to add it to the git, could you tell me? then i could add it to my version

SeriousBuggie commented 1 year ago

I will want test it for be sure it not goes bad. I will add it later.

Anyway it return back messages about double kill and possible affect other mods fix issues for it.

Shot00643 Shot00642 Shot00641 Shot00640 Shot00639 Shot00638 Shot00637

Maybe it wrong. Need check for be sure.

prom6 commented 1 year ago

your fix seems to work perfectly on my end, thanks