search

stijnfrishert / libLSDJ

Library for working with the LSDj save file format
MIT License
93 stars 6 forks source link

lsdsng-import -f ignore subfolders (and non-.lsdsng files) #17

Closed urbster1 closed 6 years ago

urbster1 commented 6 years ago

if there are .lsdsng's in a folder and -f is used, if there is a subfolder in the same folder, lsdsng-import will throw an error that the subfolder cannot be opened for reading

stijnfrishert commented 6 years ago

Duly noted. It should just pull all .lsdsng's from all sub(-sub-sub-sub)-folders?

urbster1 commented 6 years ago

actually i was thinking the opposite - it shouldn't do recursion in folders at all, only the top level

On Wed, Jun 27, 2018 at 4:45 AM, Stijn Frishert notifications@github.com wrote:

Duly noted. It should just pull all .lsdsng's from all sub(-sub-sub-sub)-folders?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/17#issuecomment-400592212, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWeCFvfF2iwEgjGKtoVAQhW28WdB0ks5uA0YOgaJpZM4U4F4d .

stijnfrishert commented 6 years ago

And then disregard anything that isn't an .lsdsng

urbster1 commented 6 years ago

i think so. that way for instance if there is a .sav in there it won't get added without explicit -s

On Wed, Jun 27, 2018 at 10:53 AM, Stijn Frishert notifications@github.com wrote:

And then disregard anything that isn't an .lsdsng

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/17#issuecomment-400702182, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWbvO6WOqyDdWyE9W6_9WROtMT3N4ks5uA5yDgaJpZM4U4F4d .

urbster1 commented 6 years ago

but also it won't cause an error

On Wed, Jun 27, 2018 at 10:55 AM, Aaron U urbster1@gmail.com wrote:

i think so. that way for instance if there is a .sav in there it won't get added without explicit -s

On Wed, Jun 27, 2018 at 10:53 AM, Stijn Frishert <notifications@github.com

wrote:

And then disregard anything that isn't an .lsdsng

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/17#issuecomment-400702182, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWbvO6WOqyDdWyE9W6_9WROtMT3N4ks5uA5yDgaJpZM4U4F4d .

stijnfrishert commented 6 years ago

Fixed (will be there for next build)!

Also ignores hidden files now (starting with a dot on unix).