search

stijnfrishert / libLSDJ

Library for working with the LSDj save file format
MIT License
93 stars 6 forks source link

lsdsng-tools change KIT P/L/V from FAST to STEP #24

Closed urbster1 closed 6 years ago

urbster1 commented 6 years ago

Using lsdsng-export and lsdsng-import on this .sav changes KIT instrument 26 from FAST to STEP. https://defensemech.com/REVISION.sav

stijnfrishert commented 6 years ago

Thanks, will look into this!

urbster1 commented 6 years ago

Both lsdsng-export and lsdsng-import are causing issues. They also seem to be garbling some of the instrument names.

urbster1 commented 6 years ago

Here's what I think (and feel free to delete this bug and create an enhancement) - lsdsng-export and -import should be entirely version-agnostic. They should only deal with compression/decompression and reading bytes for song titles/version numbers. A new tool should be created to convert songs between versions.

urbster1 commented 6 years ago

also, it's naming all of the instruments after the last instrument or something. I dunno, something really strange is going on lol

stijnfrishert commented 6 years ago

Gonna keep this issue, because the bug is still a bug even if we split this off in different tools. I'll create another issue for that.

urbster1 commented 6 years ago

The names don't seem to be garbled in v1.0. It also seems like the volume col in tables is getting weird data. I can provide another example lsdsng if that will help

On Fri, Jul 27, 2018, 7:54 AM Stijn Frishert notifications@github.com wrote:

Gonna keep this issue, because the bug is still a bug even if we split this off in different tools. I'll create another issue for that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/24#issuecomment-408396984, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWTz1zG3MPjZ__KpEd_v46V0KAMisks5uKv9sgaJpZM4VVCCW .

stijnfrishert commented 6 years ago

Sure, if you've already got one you can upload it here :)

urbster1 commented 6 years ago

https://drive.google.com/drive/mobile/folders/166yXlaOjb99nKyEYtZ3C-3jLRgm3l8l_

On Fri, Jul 27, 2018, 8:25 AM Stijn Frishert notifications@github.com wrote:

Sure, if you've already got one you can upload it here :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/24#issuecomment-408403872, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWaKmuIQTt9WoADlVBqu7onGtmujkks5uKwa-gaJpZM4VVCCW .

stijnfrishert commented 6 years ago

Fixed PLV, but turns out loop2 was also written incorrectly. Both are fixed