search

stijnfrishert / libLSDJ

Library for working with the LSDj save file format
MIT License
93 stars 6 forks source link

Incorporate changes of 6.7.0 and 6.8.0 (WAV speed and length) #31

Closed stijnfrishert closed 6 years ago

stijnfrishert commented 6 years ago

http://littlesounddj.wikia.com/index.php?title=.sav_structure&diff=5227&oldid=5214

urbster1 commented 6 years ago

unfortunately this was a format-breaking change and wave instruments no longer import/export properly on 6.8.0

urbster1 commented 6 years ago

may as well make this 6.8.1 since now grooves are also changed!

stijnfrishert commented 6 years ago

Could you make that into a new issue? I like to keep these things seperated.

urbster1 commented 6 years ago

no

On Mon, Sep 3, 2018 at 6:46 AM, Stijn Frishert notifications@github.com wrote:

Could you make that into a new issue? I like to keep these things seperated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/31#issuecomment-418077121, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWe7hPoCZ125T9TcbPffmq0gwPKK6ks5uXQijgaJpZM4V5rQU .

stijnfrishert commented 6 years ago

Perfect

stijnfrishert commented 6 years ago

Ok, so apparently this changed in 6.7.0 and not 6.8.0, but Johan has eradicated 6.7.0 from existence. Still, and I put this here for future reference: the wav speed changed with format version 6.

6.8.0 moves to fmt version 7, presumably for the groove changes, but WAV speed already changed at v7.

stijnfrishert commented 6 years ago

WAV Speed and length changed in 6.7.0 (v6) and then again in 6.8.0 (v7) because the defaults were wrong.