search

stijnfrishert / libLSDJ

Library for working with the LSDj save file format
MIT License
93 stars 6 forks source link

lsdj-wavetable-import save support #41

Closed urbster1 closed 5 years ago

urbster1 commented 6 years ago

I just thought it would be nice if we don't bother to worry about which song we're patching into, just patch directly into whatever is in the save file working memory

stijnfrishert commented 5 years ago

Yeah, perhaps leaving out the song index means working memory song

urbster1 commented 5 years ago

I came here to add this as an issue and it's already been added! hahaha XD

urbster1 commented 5 years ago

Just to clarify, I definitely think we should only worry about the working memory song and not worry about requiring an index. Open to feedback on that

stijnfrishert commented 5 years ago

Well, it's already in there so why not make that opt-in for the occasional use?

stijnfrishert commented 5 years ago

Ok, wait. But right now this tool only imports into .lsdsng's, right? So what you're suggesting is another mode in which it takes in a .sav and patches into the wm song?

urbster1 commented 5 years ago

Yes, correct

On Thu, Jan 31, 2019, 3:16 PM Stijn Frishert notifications@github.com wrote:

Ok, wait. But right now this tool only imports into .lsdsng's, right? So what you're suggesting is another mode in which it takes in a .sav and patches into the wm song?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/41#issuecomment-459489950, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWeH0ycLULNdm_Sixd4Iv054QydcXks5vI08cgaJpZM4YQ0Q_ .

stijnfrishert commented 5 years ago

Ok, makes sense. Will do.