stijnfrishert / libLSDJ

Library for working with the LSDj save file format
MIT License
93 stars 6 forks source link

lsdj-wavetable-import: trying to write noise.snt doesn't create all values properly #42

Closed urbster1 closed 5 years ago

urbster1 commented 6 years ago

trying to write this .snt into this save file doesn't create the values as saved in the .snt

snttest.zip

stijnfrishert commented 6 years ago

Thanks, will look at this when I find the time :)

stijnfrishert commented 6 years ago

Ehm, it does on my end?

You double checked with a hex editor if they correspond? If not, are some frames incorrect, or all of them?

I used lsdj-wavetable-import "./(EMPTY).00.WM.lsdsng" "./noise.snt" 0

image

urbster1 commented 6 years ago

let me check this again...

On Tue, Nov 27, 2018 at 2:07 PM Stijn Frishert notifications@github.com wrote:

Ehm, it does on my end?

You double checked with a hex editor if they correspond? If not, are some frames incorrect, or all of them?

I used lsdj-wavetable-import "./(EMPTY).00.WM.lsdsng" "./noise.snt" 0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/42#issuecomment-442179088, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWfRGJTSlyRO0wii1WtBtEjg5NrM9ks5uzY10gaJpZM4YQ28n .

urbster1 commented 6 years ago

I used lsdj-wavetable-import.exe (EMPTY).00.lsdsng noise.snt 7 and got this save. notice how frames 75-7F are the same but should be different... (EMPTY).00.lsdsng.zip

urbster1 commented 6 years ago

i did open up a hex editor when trying this initially and just pasted in the wave data into the working memory song

urbster1 commented 6 years ago

but i don't think it's possible to do with a .lsdsng since it's compressed right?

urbster1 commented 6 years ago

my save also has other wave data already patched in so you may try patching it over existing data since I had to manually confirm overwriting it

stijnfrishert commented 6 years ago

Ok thanks, I'll check with these settings! .lsdsng is compressed yes, so you wouldn't be able to copy/paste in the wavetable manually. (I was just talking about comparing hex in the .snt with the visual byte values surrounding the waves in lsdj).

urbster1 commented 6 years ago

gotcha, thanks!

On Wed, Nov 28, 2018 at 3:32 AM Stijn Frishert notifications@github.com wrote:

Ok thanks, I'll check with these settings! .lsdsng is compressed yes, so you wouldn't be able to copy/paste in the wavetable manually. (I was just talking about comparing hex in the .snt with the visual byte values surrounding the waves in lsdj).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/42#issuecomment-442362496, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWdPsJHVLdYv7Ko7ZIauN6WBs-5_Rks5uzko1gaJpZM4YQ28n .

stijnfrishert commented 6 years ago

Ok, weird stuff is happening, because on my system it totally runs fine (I did use --force). How many frames does the cmd line say it wrote after execution?

urbster1 commented 6 years ago

what if you don't use force but just use 'y' at the prompt? let me run again and see

On Tue, Dec 4, 2018 at 4:09 PM Stijn Frishert notifications@github.com wrote:

Ok, weird stuff is happening, because on my system it totally runs fine (I did use --force). How many frames does the cmd line say it wrote after execution?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/42#issuecomment-444259200, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWcDDs_LRB-rc8EvIIHMrYYBDDpNzks5u1uSegaJpZM4YQ28n .

urbster1 commented 6 years ago

Some of the wavetable frames you are trying to overwrite already contain data. Do you want to continue? y/n > y Successfully wrote 16 frames starting at 96 to (EMPTY).00.lsdsng

stijnfrishert commented 6 years ago

I'll try without force. Also, did you use another index than 7 this time, because otherwise that 96 doesn't make sense.

urbster1 commented 6 years ago

Screenshots of the hex values image image

urbster1 commented 6 years ago

yeah sorry i used 6. but it's doing the same thing

On Tue, Dec 4, 2018 at 4:15 PM Stijn Frishert notifications@github.com wrote:

I'll try without force. Also, did you use another index than 7 this time, because otherwise that 96 doesn't make sense.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/42#issuecomment-444260980, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbBWUSww_jTM2OfZw_XmRJ0ERuO0aPMks5u1uX0gaJpZM4YQ28n .

urbster1 commented 6 years ago

could it be an issue with lsdsng-import then? i have no way to check if it's valid in the lsdsng itself

stijnfrishert commented 6 years ago

Can you send just the exported .lsdsng?

urbster1 commented 6 years ago

(EMPTY).00.zip

urbster1 commented 6 years ago

i said "no way to check" but i guess i could check it with LSDManager

stijnfrishert commented 6 years ago

Which is what I just did, haha. Seems to be a problem in the wavetable import, so that's good news I guess.

Perhaps something Windows specific? I'll add a --verbose and send you a new build later this week. Your import just stops halfway through the file, and it's hard to know why without more output.

urbster1 commented 6 years ago

ok! very weird. thanks!

stijnfrishert commented 5 years ago

Problem was that the file wasn't opened as binary