search

stijnfrishert / libLSDJ

Library for working with the LSDj save file format
MIT License
93 stars 6 forks source link

Make v2 handle Drum MAX again #80

Closed stijnfrishert closed 4 years ago

stijnfrishert commented 4 years ago

@urbster1 You said something about this being removed again in some version?

urbster1 commented 4 years ago

It was removed in v6.3.3, although that byte is not overwritten, so if you load a v6.1 song into v6.3+ and then back to 6.1, it will still apply DRM MAX as it was originally set.

On Wed, Feb 26, 2020, 4:28 PM Stijn Frishert notifications@github.com wrote:

@urbster1 https://github.com/urbster1 You said something about this being removed again in some version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/liblsdj/issues/80?email_source=notifications&email_token=ABLMCWKYYM7DSRQZHZLVERLRE3NHTA5CNFSM4K4OME22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IQTAM3A, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLMCWKKLME6HQE5XLH5RK3RE3NHTANCNFSM4K4OME2Q .

stijnfrishert commented 4 years ago

Ok that's good news. The set/get funcs could still exist, and beyond 6.3+ it just won't do anything for LSDj :)