search

stijnfrishert / libLSDJ

Library for working with the LSDj save file format
MIT License
91 stars 6 forks source link

lsdsng-import directory recursion #83

Closed urbster1 closed 3 years ago

urbster1 commented 4 years ago

If -f is used by lsdsng-export to put songs in folders, it would be nice to recursively check subfolders for .lsdsng files.

stijnfrishert commented 3 years ago

@urbster1 Wait, the title mentions lsdsng-import, but the description mentions lsdsng-export. Which one are we talking about?

urbster1 commented 3 years ago

both - lsdsng-export places lsdsng files into their own folders with the -f option. so when calling lsdsng-import, it would be nice to have folder input as well. otherwise you're stuck manually adding each lsdsng because each one is in a separate folder. make sense?

On Mon, Nov 9, 2020 at 5:12 AM Stijn Frishert notifications@github.com wrote:

@urbster1 https://github.com/urbster1 Wait, the title mentions lsdsng-import, but the description mentions lsdsng-export. Which one are we talking about?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/libLSDJ/issues/83#issuecomment-723912662, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLMCWNEOWTO2T5VJF67CXDSO657FANCNFSM4NKIPU7A .

urbster1 commented 3 years ago

actually I think it does have folder input right? but it won't check subfolders, so if you have one folder as the input but the folder contains a set of subfolders each with a .lsdsng, none of those songs are added to the import. that's what the issue is about IIRC

On Tue, Nov 10, 2020 at 12:52 PM Aaron U urbster1@gmail.com wrote:

both - lsdsng-export places lsdsng files into their own folders with the -f option. so when calling lsdsng-import, it would be nice to have folder input as well. otherwise you're stuck manually adding each lsdsng because each one is in a separate folder. make sense?

On Mon, Nov 9, 2020 at 5:12 AM Stijn Frishert notifications@github.com wrote:

@urbster1 https://github.com/urbster1 Wait, the title mentions lsdsng-import, but the description mentions lsdsng-export. Which one are we talking about?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stijnfrishert/libLSDJ/issues/83#issuecomment-723912662, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLMCWNEOWTO2T5VJF67CXDSO657FANCNFSM4NKIPU7A .

stijnfrishert commented 3 years ago

Aah right! Yeah, it does have folder support, but doesn't read them recursively.

Except for the fact that I happened to add that yesterday when refactoring some code, so I guess this is solved then 😀