Incorporate format changes up to 8.9.3

stijnfrishert / libLSDJ

Library for working with the LSDj save file format

MIT License

93 stars 6 forks source link

Incorporate format changes up to 8.9.3 #91

Closed stijnfrishert closed 3 years ago

stijnfrishert commented 3 years ago

[x] 8.1.0 (v11)
[x] 8.6.0 (v12)
[x] 8.8.0 (v13)
[x] 8.8.1 (v14)
[x] 8.8.6 (v15)
[x] 8.8.8 (v16)
[x] 8.9.3 (v17)

https://www.littlesounddj.com/lsd/latest/CHANGELOG.txt

stijnfrishert commented 3 years ago

Implemented ADSR setters and getters. Gonna wait for Johan to update the manual to double check if everything is correct.

I've decided that both the env and adsr functions co-exist, and it's up to the user to check fmt version first before calling either. Otherwise it's UB. Diverging within the functions and trying to solve this for users is only going to muddy the interface.

stijnfrishert commented 3 years ago

Not sure what's happening in 8.6.0, gotta ask Johan

stijnfrishert commented 3 years ago

8.8.0:

Added comments about range for ADSR levels
Added UB comment to pulse/noise set/get_length

stijnfrishert commented 3 years ago

8.8.1:

Nothing to do, we're not interpreting command values, just exposing bytes

stijnfrishert commented 3 years ago

8.8.6:

Nothing to do, we just expose the ADSR speed bits,

stijnfrishert commented 3 years ago

8.9.3:

Nothing to do, we just expose command values without interpreting them

stijnfrishert commented 3 years ago

8.6.0:

Added comment to shape about it not being available after 8.6.0

Asked @urbster1 about 8.8.8, not sure what is changed there.

stijnfrishert commented 3 years ago

8.8.8:

Moved wave synth/wave to byte 3

stijnfrishert commented 3 years ago

Don't need to do anything for 8.6.0