Compiling Delphi Berlin 10.1

[stijnsanders]

I won't be pulling, please see my most recent commit where I used a single compiler-conditional on top.

[OneideLuizSchneider]

Hi I updated today, but it still does not compile.

[stijnsanders]

Could you check (with Ctrl+Click on 'Seek') what is the exact type used in the declaration of IStream in your version?

[stijnsanders]

Did some more gophering, appears that older Delphi versions also support LargeUInt (but patch it through to Int64 just as well) Please check if it works with the current master?

[OneideLuizSchneider]

Hi, Missing implementation of interface method IPersistStream.GetSizeMax

[stijnsanders]

Does it compile if you only change GetSizeMax' argument to type Largeint?

[OneideLuizSchneider]

Yes it works in Delphi Berlin, but in Delphi 2010 it does not compile, because it is Int64. With the differative build works correctly: {$IFDEF VER310} p1,p2:UInt64; {$ELSE} p1,p2:int64;
{$ENDIF}

[stijnsanders]

nng, it really would be nice if there were just a single type that works with all, could you please try with p1,p2:LargeInt; or p1,p2:LargeUInt; just one more time, of that doesn't work, I'll put in the {$IFDEF VER310}

[OneideLuizSchneider]

Hi, Delphi 2010 Build Ok, in Delphi Berlin erro, according image. Try to merge a pull request.

[stijnsanders]

And with LargeUInt?

[OneideLuizSchneider]

In Delphi Berlin compile, but error in Delphi 2010 because it is Int64.

[stijnsanders]

Ok, see my recent commit. I hope this does it. I also hope anyone that knows any version that needs extra contidionals, lets me know.

[OneideLuizSchneider]

Delplhi Berlin Interface is different. In the Delphi 2010 interface is also different. This should be Largeint.

[stijnsanders]

ok, hope this is the one

[OneideLuizSchneider]

• Should be LargeInt, not another type, the interface requires this.

• And in the other image, it should be UInt64 for berlin and int64 for 2010.

  Please see my PULL REQUEST this is correct.

[OneideLuizSchneider]

So compile properly, please review.

bsonDoc.zip

[stijnsanders]

And that compiles in both versions?

[OneideLuizSchneider]

Yes, I can do another pull request if it is easier.

[stijnsanders]

I've committed something already, please check if it's ok. Your request has motivated me to look into replacing TMongoWire's bsonDoc with jsonDoc and a separate unit to load/save to/from BSON, chances are there won't be any IPersistStream involved any more.

[OneideLuizSchneider]

Hi It is not correct yet. Example below is that I have set this correct.

[stijnsanders]

very very strange

[OneideLuizSchneider]

No wonder this is Delphi.

[OneideLuizSchneider]

Build in Delphi 2010 and Berlin OK. Thanks for help.

[stijnsanders]

For your information: I've completed the switch to jsonDoc, and IPersistStream has moved out of the picture. If you switch to v1.1, let me know how it works for you.

[OneideLuizSchneider]

Hi, adjust the jsonTools.pas for compilation correctly, image below.

[stijnsanders]

Ah, I thought it was all fixed with eliminating IPersistStream, but basic IStream is still supported, see my last commit

[OneideLuizSchneider]

Hi, Must be VER310, not VER130. image below.

[stijnsanders]

I feel stupid now, see my corrective commit

[OneideLuizSchneider]

Hi, build ok...