Split reflective into a library

jrote1 commented 8 years ago

I have split reflective into a library as I am working on some new changes and it was getting big. This change set only includes the splitting into a library.

stijnvanbael commented 8 years ago

You've been really busy, that's great! I like where this is going, although I would change a few things:

Stick related classes and functions together in the same source file. Dart does not follow the one source file per class idiom from Java and C#. Dart gets away with it since source code tends to be more terse. I'd put the subclasses of FieldReflection in the same source file as FieldReflection. The convenience methods for obtaining a TypeReflection should be in the same source file as TypeReflection. And Maps and Objects could go in util.
I prefer to keep the name of the library "reflective" instead of "reflective.reflective"
You haven't done it in this commit, but I've seen it in the other two pull requests. Try to keep the method declaration and the opening bracket on the same line. Although it's not in the Effective Dart style guide, this seems to be the convention.

jrote1 commented 8 years ago

I will do this now
But what should the library name be for the extracted library as it can't be reflective or would you like all of the files to be part of the main library?
I have formatted all of the files using dart format could you comment on the method that is wrong thanks

jrote1 commented 8 years ago

Once this branch is merged I will update my other branch before you merge that.

stijnvanbael / reflection

Split reflective into a library #2