search

stijnvanbael / reflection

MIT License
1 stars 2 forks source link

Dev #6

Closed matdavies closed 8 years ago

matdavies commented 8 years ago

Hi Stijn,

Got another pull request for you here. I hope you don't mind us contributing here, and making some breaking changes... :)

We're using your library for a few things, one of which is a dart to c# converter, and for that, we needed more information about generic arguments to types. So I've added a "genericArguments" property and deprecated the existing "arguments" property. The reason I did that is because I needed information about the names of the generic arguments, as well as their types.

Let me know if you think there is a better way to do what I've added here, and let me know if you have any questions about this pull request, or suggestions for refactoring :)

Cheers,

Matthew

stijnvanbael commented 8 years ago

Hi Matthew,

It's great to see Reflective being used. I can only encourage contributions. Thanks for the great work!

PS: That's a really exciting use case you've got there

Best regards, Stijn