Update SnapClient Binaries of ios app

stijnvdb88 / Snap.Net

A cross-platform control client and player for https://github.com/badaix/snapcast

GNU General Public License v3.0

119 stars 11 forks source link

Update SnapClient Binaries of ios app #51

Open DerPicknicker opened 9 months ago

DerPicknicker commented 9 months ago

Hi,

I bought your app and all in all it works fine. I encountered some bugs and I don't know if this happens due the fact that the ios app uses older snapclient versions.

If I pressed the play button and send a stream to the device it won't start playing. Only if I re-toggle the play button or if I sync it manually to an already playing snapclient.
If I ungroup the iOS client and start a new stream to this device it also won't start playing

So it would be nice if you can update the snapclient and I can test it on my side of this addresses my mentioned issues.

Best regards

DerPicknicker commented 9 months ago

@stijnvdb88 do you have the time for looking into it..?

stijnvdb88 commented 9 months ago

Hi! unfortunately it's not that simple; the iOS client does not exactly use an older snapclient version, it uses its own version of snapclient (a C# port that I wrote when the latest version was 0.14). That said, since 0.14 and 0.17 there haven't been any major changes to the player protocol, so hopefully this is just a bug in the app and not an issue with the client being outdated. I tested the snapclient port on Windows against 0.17 and it still seems to work fine. Can you tell me which iOS version you're on? Also, what do you mean when you say "syncing manually to an already playing snapclient" ? I'm not sure I'll be able to make updates to the iOS app anytime soon as I don't have the required hardware right now, the Mac device I was using for development is now deemed too old by Apple and can't be used to make publishable builds anymore.

Best regards

DerPicknicker commented 9 months ago

Hi @stijnvdb88 ,

I am using the iOS version 17.1.2. And the latest version of the app. Is the iOS Code also open source and on GitHub?

Regarding the bugs: (Let's try to explain it in different words...):

The app won't start playback automatically unless you're toggling play again. I start a stream to the iOS client. But the audio starts only if I stopping and starting the playback (play button ) inside the app.
The only way to get automatically audio is if I syncing the iPhone to another stream which is already played by another snapcast player. An initial stream is only played if you toggling the play button after the stream starts.

I hope this makes it a little bit clearer.

stijnvdb88 commented 9 months ago

That helps, thanks! Yes, all the code is open source; the iOS app is part of the .NET solution in this repo. If you clone it and open it in Visual Studio you should find the Snap.Net.Mobile.iOS subproject inside of it.

DerPicknicker commented 9 months ago

I will try to have a look. Would be great if you can do it also on your side.