stijnwop / manureSystem

Manure System modification for Farming Simulator 2022
GNU General Public License v3.0
97 stars 58 forks source link

How making the Smety Mod Xerion 3000 Saddle Trac frontdock pump right ? #127

Closed Lactic68 closed 4 years ago

Lactic68 commented 4 years ago

Hi Wopster,

I think Smety has already contacted you but do you have planned to help him to finish his front liquid manure pump of his Xerion 3000 Saddle Trac ? For now, he had to code the tank inside the front pump which is really odd and make the tractor completely unbalanced .. as you can see here

Again, thanks for your great mod, very good addition to the game.

stijnwop commented 4 years ago

No he did not, and he could have simply made the frontdock function like a frontdock with the standalone pump option. Which is done in some cases already so no need to make frontdock act like a 'tank'.

Lactic68 commented 4 years ago

Hi Wopster,

Thank you for your quick answer. I tried to contact Smety by email but his mailbox is saturated. Do you think it is possible to fix his mod by editing it to make it right with your manure system ? I would like to help sorting this out but I will need a walkthrough in order to know what I have to do (XML editing only or Giants Editor).

Lactic68 commented 4 years ago

Hi, I have tried to edit the modDesc.xml by adding this : `

</specializations>`

and this `

</vehicleTypes>`

But when I try to buy the Xerion in the shop, nothing appears. It seems that the mod won't load. When I remove the specializations line, it works.

KITT3000 commented 4 years ago

@Lactic68 But why are you adding this specialization to a vehicle type for a tractor instead of making a new type of vehicle for the pump itself?

Lactic68 commented 4 years ago

@KITT3000 The pump (zunhammer_pump.xml) is an implement of this tractor which is located in the same mod. I would gladly use your advice to do this the right way. This mod is divided in three parts that have to work together :

KITT3000 commented 4 years ago

Pump has

<vehicle type="manureBarrel">

in XML, so you so you change manureBarrel to your name like pumps and add it in modDesc

<vehicleTypes>
   <type name="saddletrac" parent="baseDrivable" className="Vehicle" filename="$dataS/scripts/vehicles/Vehicle.lua">
     <specialization name="cover" />
     <specialization name="crabSteering" />
  </type>
  <type name="pumps" parent="implement" filename="$dataS/scripts/vehicles/Vehicle.lua">
     <specialization name="turnOnVehicle"/>
     <specialization name="fillUnit"/>
     <specialization name="manureSystemVehicle"/>
  </type>
</vehicleTypes>
Lactic68 commented 4 years ago

@KITT3000 Thank you so much for your quick help 👍🏻 Tractor, frontdockpump and tank are now OK but when I pump slurry the tank doesn't fill :-( Should I add a specific type to the tank also ? For now, the tank has this : <vehicle type="manureBarrel">

KITT3000 commented 4 years ago

But this tank available in this mod?

Lactic68 commented 4 years ago

Yes, this tank is in this mod too

KITT3000 commented 4 years ago

Well, since when can you pump liquid wirelessly?

Lactic68 commented 4 years ago

So we have to add one hose in this mod ? What is weird is that the modder has included some kind of small hose between frontdock and rear tank but is this purely aesthetic ? Do you think it is fixable in Giants Editor ?

KITT3000 commented 4 years ago

Yes, such a hose you should make.

Lactic68 commented 4 years ago

@KITT3000 Well thank you for all your advice but creating a hose between those two elements which are not in the same i3d file is beyond my skills in Giants Editor.

KITT3000 commented 4 years ago

It is enough to set only 2 transformGroups, one in the pump, the other next to the tank, as it is in the case of a tanker or seed drills with an additional seed hopper on the front three-point linkage

Lactic68 commented 4 years ago

Do you have an example mod in mind which use this method ? So I can learn how to do this. Is the fact that there are 2 different i3d file going to be an issue ?

Lactic68 commented 4 years ago

I just checked in GE and they might be transformGroups (both named "hose_point") we can use. For the tank : Node 0>3 For the pump : Node 0>5

but I don't know how to connect them

KITT3000 commented 4 years ago

You have an example in the machines in the base game. Kuhn TF1500 (it might be your pump):

<connectionHoses>
        <hose inputAttacherJointIndices="1" type="TOOL_CONNECTOR_TOP_RIGHT" node="topRightPipe" length="2" diameter="0.14" isTwoPointHose="true"/>
    </connectionHoses>

Kuhn BTF4000 (it might be your tank):

 <connectionHoses>
        <hose inputAttacherJointIndices="1" type="TOOL_CONNECTOR_TOP_RIGHT" node="topRightPipe" length="1.5" diameter="0.14" isTwoPointHose="true"/>
    </connectionHoses>

John Deere 6R (the stiff pipe the hoses connect to appears when you hook up these 2 machines):

<connectionHoses>
<toolConnectorHose mountingNode="rightPipe">
            <startTarget attacherJointIndices="2 5" type="TOOL_CONNECTOR_TOP_RIGHT" node="rightPipe_frontConnector"/>
            <endTarget attacherJointIndices="1 3 4" type="TOOL_CONNECTOR_TOP_RIGHT" node="rightPipe_backConnector" straighteningFactor="2"/>
        </toolConnectorHose>
</connectionHoses>

btw. Do you have any direct contact with Smety?

Lactic68 commented 4 years ago

Hi @KITT3000 , Thank you for your example. Applied to this mod I only found this :

For the Zunhammer_pump, when attached to the front, some hoses appears - and they are all joining the center of the tractor where the tank is located but no connectionHoses are declared in this xml : `

</attachable>`

For the Zunhammer tank only one connectionHoses is declared but it is for the back of the tank (to connect some implement): `

</connectionHoses>`

About this tank, there is indeed a node named "hose_point" located on the far front of the tank (not directly on it) but it is not used in any way. Perhaps some collision issue when passing through the tractor body ? What do you think ?

For the Xerion 3000 Saddle Trac, lot of connectionHoses are declared, here is what I found. I'm asking myself why has Smety not activated the rightPipe (by commenting it) : `

` I can't reach Smety (his mailbox has overquota issue) and I don't have any facebook account to messenger him. I don't think either that he is looking at the Giants Forums where users have issue with this mod. So this is only a first attempt to sort this out and to do this right with your already kindful help (if it doesn't bother you of course). I wonder why Smety didn't contact you or Wopster in his creation process at first.
Lactic68 commented 4 years ago

@KITT3000 Some news on Smety's facebook (CMT Software). Apparently he has tried multiple ways of doing it right in order to make the rear tank the real tank and not the pump but so far unsuccessfully, I quote :

CMT software to Michael Döringer : pump and tank in one, doest work arm filling.. I test 1. zunhammer is configuration 2. zunhammer is one tool, 3. zunhammer is pump and tank (2 tools) problem is arm collision, Manure system..

An other comment says that @stijnwop has a WIP about the zunhammer Profifant, I quote :

Tobi Wittmann CMT software Wopster is writing a script for the zunhammer Profifant, it's the same system, but it's work in Progress

Michael Döringer CMT software maybe contacting Wopster? Maybe he has an good idea? He is although working on a front filling arm.

Lactic68 commented 4 years ago

Smety has published an update and yet the manure system works nicely with it. The tank is still in the frontdock pump but the weight balance is fixed and same for the filling display.

I will close this issue now, thank you for your help @KITT3000 and have a nice day 👍🏻

stijnwop commented 4 years ago

There's just no need for a tank in the dock.. thats also not how it's suppose to work.

In my support_en channel on Discord I helped a guy who also needed to setup a frontdock.

isStandalone="true" useStandalonePumpText="false"

Key is to add those to the pumpMotor entry.

Lactic68 commented 4 years ago

Hi @stijnwop , thank you for your advice but right now I can't reach Smety (I do not have a facebook account). Maybe you could offer him some help by sending him a facebook messenger and invite him to your discord support server ?

I'm sure his mod will be even better with you two working together to make this right ; -)