stil4m / elm-analyse

A tool that allows you to analyse your Elm code, identify deficiencies and apply best practices.
https://stil4m.github.io/elm-analyse/
MIT License
417 stars 56 forks source link

Is this still being maintained? #265

Open ikisler opened 1 year ago

ikisler commented 1 year ago

Hey there, is this library is still being maintained? The last release was ~3 years ago, and there are open security advisories (see https://github.com/stil4m/elm-analyse/issues/257).

Would there be any interest in bringing on another maintainer?

Alternatively, does anyone own a fork where they are maintaining security patches? I looked through the existing forks on GH but didn't see any that looked up to date.

Thank you!

jfmengels commented 1 year ago

Hi @ikisler

This tool is not being actively maintained no. I would highly recommend using elm-review which is actively maintained and a more powerful tool than elm-analyse.

ikisler commented 1 year ago

Thanks for the quick response @jfmengels! I will check out elm-review as a replacement.

cyberglot commented 1 year ago

Maybe put an archive badge on it? 😬

jfmengels commented 1 year ago

@stil4m Would you be fine with me officially deprecating the tool?

stil4m commented 1 year ago

Hi Jeroen,

Yes. Do it :)

On 2 Nov 2022, at 16:46, Jeroen Engels @.***> wrote:

@stil4m https://github.com/stil4m Would you be fine with me officially deprecating the tool?

— Reply to this email directly, view it on GitHub https://github.com/stil4m/elm-analyse/issues/265#issuecomment-1300727049, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFOFKFEHH5FXPN2DOIMKEDWGKEF5ANCNFSM6AAAAAAQ46DCJU. You are receiving this because you were mentioned.

AntouanK commented 1 year ago

@jfmengels If I'm honest, I don't see why it should be "deprecated". This tool still does what it says it does. elm-review can do the same, for sure, but needs lots configuration for it. I tried to replicate some of the elm-analyse features but I need to spend time to learn and write rules. elm-analyse does what it does out-of-the-box.

I understand the dependencies might be an issue. Either because of the installation step, or because of security issues. @ikisler

@stil4m I forked the repo and updated all the npm dependencies. The tool works fine with just some minor tweaks.

I also removed all the INFO logging ( it was too noisy for me ) and put it behind a flag. Plus I made a bundle js file that can run on it's own, to not need any npm install or additional steps.

https://github.com/AntouanK/elm-analyse/pull/1

I'll use that from now on, but if you want I can make a PR here so you can update the original elm-analyse

jfmengels commented 1 year ago

It should be deprecated because the project is not maintained anymore, and because a different solution — with better and more accurate reports and more powerful features — exists.

Pretty much all of Elm Analyse's features exist in elm-review (and all of its rules can be found somewhere).

elm-analyse does what it does out-of-the-box.

Starting with a default configuration (like below) gives you the same thing, and more.

elm-review init --template jfmengels/elm-review-config/application
maca commented 1 year ago

It just works ;)