Add Range.empty and Node.empty

stil4m / elm-syntax

Elm syntax in Elm

MIT License

94 stars 28 forks source link

Add Range.empty and Node.empty #182

Closed jfmengels closed 1 year ago

jfmengels commented 1 year ago

Introduces Range.empty (fixes #113)
Introduces Node.empty (fixes #115) Can be reviewed commit by commit

MartinSStewart commented 1 year ago

This PR is for the next major release of elm-syntax right? Just making sure were not accidentally adding a breaking change into the current version.

jfmengels commented 1 year ago

No, this is for V7, and it only makes for a MINOR version change. I'll remove Range.emptyRange for V8 though yes.

MartinSStewart commented 1 year ago

I think I merged these PRs in the wrong order. This PR wants to be merged into cleanup-processing but I just merged cleanup-processing into master. Should this be merged into master?

jfmengels commented 1 year ago

Yes this one should be merged into master (all of them I think, I'll have to check). But I'll take care of merging them, don't worry about that :+1:

jfmengels commented 1 year ago

Pushed to master :+1: