search

stil4m / elm-syntax

Elm syntax in Elm
MIT License
94 stars 28 forks source link

Add information to Expression about which quotes a Literal is made of #189

Closed jfmengels closed 1 year ago

jfmengels commented 1 year ago

Fixes #57

MartinSStewart commented 1 year ago

If we have a StringLiteralType, should we also have a IntegerType instead of having Integer and Hex expressions?

jfmengels commented 1 year ago

Possibly yes. There is a separate issue in https://github.com/stil4m/elm-syntax/issues/108 for that one though, so we can brainstorm that one over there.

Btw, I'm open to alternative strategies for providing the string literal type, though I think this one is pretty good :slightly_smiling_face:

MartinSStewart commented 1 year ago

Yeah, I prefer this approach over having two different variants in string literals in Expression