stil4m / elm-syntax

Elm syntax in Elm
MIT License
94 stars 28 forks source link

Fix stack overflow during post-processing #191

Closed jfmengels closed 1 year ago

jfmengels commented 1 year ago

I introduced an infinite recursion in 03ce4ff14672b7d4f5e49a9a978ddc2df51b01c, which wasn't caught because we have few parser tests that do post-processing, and none of them had a single function call.

I would very much like to go back to the previous version of the visitExpression that wasn't split in 2 (to reduce the size of the call stack and improve performance), but I can't seem to wrap my around it in a way that doesn't break the re-balancing of the tree or result in a infinite recursion again.