search

stil4m / elm-syntax

Elm syntax in Elm
MIT License
92 stars 26 forks source link

Add a simple elm-review rule for formatting ranges #213

Closed jiegillet closed 2 weeks ago

jiegillet commented 2 weeks ago

As I was playing around in the codebase, I was often copy/pasting the output of tests into actual tests, and I realized that the ranges/locations are shown in alphabetical order, which is the least readable order possible.

Instead of changing it by hand, I thought I would write a simple elm-review rule, so here it is.

jfmengels commented 2 weeks ago

Aha! This is great! :tada:

I used to do this with a find+replace regex in my IDE, and I had to this in a LOT of places (because until a while ago all ranges in tests were replaced by Range.emptyRange). I wrote the regex in this commit's description 427683dc229c80c5ee111f31c7a1e5f0d1a09085

But this is much better, thanks!

I'll likely rebase the pratt-parser branch soon. Let me know if that creates any trouble for you, I'll be able to jump in if/where needed to help you out.

jfmengels commented 2 weeks ago

I'll likely wait until we merge #212, to avoid any problems. Feel free to not re-arrange your ranges in that branch until then.

jiegillet commented 2 weeks ago

When you have an elm-review, everything is a rule ;)

I'll likely wait until we merge https://github.com/stil4m/elm-syntax/pull/212, to avoid any problems. Feel free to not re-arrange your ranges in that branch until then.

Sounds good!