Finish Pratt Parser implementation

stil4m / elm-syntax

Elm syntax in Elm

MIT License

92 stars 26 forks source link

Finish Pratt Parser implementation #214

Closed jiegillet closed 6 days ago

jiegillet commented 1 week ago

This PR makes all the tests pass.

I ended up reverting to the initial layout validations, I needed to tweak the case and let block parsers and it ended up working for the most part.

I did need to change some of the tests that had 1.18-era operators like !. This is technically a breaking change, so maybe Pratt parsers is better suited for V8? Putting them back in is also an option but...

I don't consider this PR final, I think should add more tests at the very least.

jfmengels commented 6 days ago

Is there anything you'd like to add to this PR? I am happy to merge this as is otherwise.

jiegillet commented 6 days ago

About a million things 😄

I think this one is fine for now, there will be more.

jfmengels commented 6 days ago

That's absolutely fine. Thank you so much for the help and keep them coming as long as you have fun with this :blush: :heart: