search

stil4m / elm-syntax

Elm syntax in Elm
MIT License
94 stars 28 forks source link

v8 names: drop -Literal #254

Open lue-bird opened 2 months ago

lue-bird commented 2 months ago

Since there's no name clashes with core types, what's "literal" between e.g. a Record, Tuple or ListLiteral?

I suggest either dropping the literal suffix (preferred by me) or only use it for Integer, Hex, Floatable, Char, String, Unit (?).

jfmengels commented 2 months ago

I think I agree. I think it makes sense to keep them on the ones that clash with core types. As far I can tell, that's only List, String, Char, Float, and maybe Integer (although it doesn't clash with Int, so no name clash, but inconsistent maybe? Though I think it's just fine like this).

lue-bird commented 2 months ago

My point was that there is no "clash with core types" ever. So I don't see why it's useful to use a suffix (that already has a clear meaning).

jfmengels commented 2 months ago

Oh ok. I think we meant different things with name clashes. You meant that you don't get compiler errors, while I meant that it's potentially confusing. Maybe my worry is not warranted though :man_shrugging: