Can't make `redirect_to` with `cablecar` functionnal with `rc2`

[jibees]

This code is functional for pre10:

        render operations: cable_car.redirect_to(
          url: MY_URL
        )

Response is:

[{"url":"/","operation":"redirectTo"}]

Unfortunately, when bumping to rc2, with the following code:

        render cable_ready: cable_car.redirect_to(
          url: MY_URL
        )

(only changing deprecated operations: to cable_ready) it does not redirect my app, probably because the response is actually empty.

• Note 1: if I use operations: instead of cable_ready: I had a deprecated warning, but the response is still empty.

  DEPRECATED: CableReady's `render operations:` call has been renamed to `render cable_ready:`. Please update your render call.

• Note 2: Running this request is a spec environnement seems ok (at a request level, not browser one), but not in browser.
• Note 3:

      cable_car.redirect_to(
        url: return_url_or_default(after_sign_in_path_for(spree_current_user))
      )

  seems ok and is equal to: #<CableReady::CableCar:0x00007fe3be5ecf28 @enqueued_operations=[{"url"=>"/", "operation"=>"redirectTo"}], @identifier="CableCar", @previous_selector=nil>

(at least json seems fine)

• Note 4: debugging with firefox give me another clue: the response is not empty and seems to be valid (ie. the right json). On Chrome, the response is still empty. Which seems to be a bit strange.

[marcoroth]

Thanks for bringing this to our attention @jibees!

As we discussed this on Discord, it only surfaced in combination with mrujs when submitting a form. mrujs added a Accept: application/vnd.cable-ready.json header to the request which caused some issues because we recently changed the CableReady MIME-Type to text/vnd.cable-ready.json in #260.

Luckily the CableCar plugin for mrujs allows the MIME-Type to be configured, like:

mrujs.start({
  plugins: [
    new CableCar(CableReady, { mimeType: "text/vnd.cable-ready.json" })
  ]
})

This seems to solve the issue. @jibees is going to open a pull request on mrujs to update the default MIME-Type for the CableCar plugin in: https://github.com/KonnorRogers/mrujs/blob/86ec3ddea227c5125b2aa946af8e27837d4dae36/plugins/src/cableCar.ts#L16

Heads-up @KonnorRogers!

I'm going to close this issue! Thank you!

[jibees]

After some research, it appears that the underlying issue was something related to Content-Type.

• The request header Accept was Accept: application/vnd.cable-ready.json, */*
• The response header Content-Type was `Content-Type text/vnd.cable-ready.json; charset=utf-8``

Actually, cable_ready changed its default ContentType recently (reference: https://github.com/stimulusreflex/cable_ready/pull/260)

And the form was actually submitted/handled via mrujs integrated with CableCar which clearly precise that form with accept header "application/vnd.cable-ready.json, */*" will be handled Source: https://mrujs.com/how-tos/integrate-cablecar

So, it's not actually a cable_ready issue. Closing here!

Thanks for the great debugging session @marcoroth ! That was very pleasant!

[jibees]

Just opened a PR on mrujs: https://github.com/KonnorRogers/mrujs/pull/209 !

[marcoroth]

Awesome, thank you @jibees!