stimulusreflex / stimulus_reflex

Build reactive applications with the Rails tooling you already know and love.
https://docs.stimulusreflex.com
MIT License
2.28k stars 172 forks source link

iFrame gets refreshed despite data-reflex-permanent #452

Closed RolandStuder closed 3 years ago

RolandStuder commented 3 years ago

Bug Report

In some cases iframes get refreshed when they shouldn't. This happens when sibling nodes get added / removed to a parent element of an iframe.

To Reproduce

MVCE https://github.com/RolandStuder/stimulus-reflex-morph-ifram-bug

Expected behavior

iframe content is not reloaded

Screenshots or reproduction

commented behavior here https://www.loom.com/share/091433753868455fa6a4cf032e430058## Versions

StimulusReflex

External tools

Browser

RolandStuder commented 3 years ago

Might be this issue here: https://github.com/patrick-steele-idem/morphdom/issues/200

leastbad commented 3 years ago

I've been working on this about 40 hours now, and I've sadly made zero real progress. I've asked for help from @snewcomer but he's likely very busy with @snewcomer things. This might just need to be documented as a warning so that I can move on with my life.

leastbad commented 3 years ago

@RolandStuder I think we should close this because it's an issue that can only be fixed in morphdom. 😿

I'm going to attempt to add something about this to the docs: https://docs.stimulusreflex.com/appendices/troubleshooting#iframe-gets-refreshed-despite-data-reflex-permanent