stimulusreflex / stimulus_reflex

Build reactive applications with the Rails tooling you already know and love.
https://docs.stimulusreflex.com
MIT License
2.28k stars 172 forks source link

Installer finds false positive controller import in esbuild setup #583

Closed julianrubisch closed 1 year ago

julianrubisch commented 2 years ago

Just found out that this line:

https://github.com/stimulusreflex/stimulus_reflex/blob/165c2fae77b164e2f82306f4c692f97040b9c7fd/lib/tasks/stimulus_reflex/install.rake#L41

fails in a new jsbundling-esbuild setup because the following is typically present:

import controllers from './**/*_controller.js'
controllers.forEach(controller => {
  application.register(controller.name, controller.module.default)
})

thought I'd make a quick note of it.

marcoroth commented 1 year ago

This should be resolved via #610

marcoroth commented 1 year ago

Resolved via #610