search

stimulusreflex / stimulus_reflex

Build reactive applications with the Rails tooling you already know and love.
https://docs.stimulusreflex.com
MIT License
2.28k stars 172 forks source link

Broken Next Page Link on Welcome Page of Docs #660

Closed aviflombaum closed 1 year ago

aviflombaum commented 1 year ago

Bug Report

The next page link on the first page of the documentation, Welcome, links to the Welcome page (itself), as opposed to the correct next page, which would be Setup

To Reproduce

Go to Welcome and see what happens on the Next Page click.

Expected behavior

Going to the next page, Setup.

Screenshots or reproduction

CleanShot 2023-05-25 at 10 08 19

I wish I knew more about vitepress so I could figure out how to fix it but looked around and nothing obvious jumped out.

<3

marcoroth commented 1 year ago

Hey @aviflombaum, thank you for reporting this!

Now that you mentioned it, I think I also looked into this in the past and haven't found a simple solution. It probably has to do with the different sections the pages are in, but I'm also not sure.

It might be worth to update vitepress and see if it resolves itself.

marcoroth commented 1 year ago

Turns out this related to the how Vitepress translates the file hello-world/index.md to the path /hello-world/.

Referencing /hello-world/ instead of /hello-world/index in the Vitepress config resolves this issue. See https://github.com/stimulusreflex/stimulus_reflex/commit/3fca17501b5679ab2c982f6c9961122d002fd8e7