search

stimulusreflex / stimulus_reflex

Build reactive applications with the Rails tooling you already know and love.
https://docs.stimulusreflex.com
MIT License
2.29k stars 174 forks source link

Fix undefined package_json during Yarn install #676

Closed mattboldt closed 11 months ago

mattboldt commented 12 months ago

Type of PR

Bug fix

Description

When running rails stimulus_reflex:install on a new Rails app using Yarn & esbuild, the following error is raised:

  --- [yarn] ----
  rails aborted!
  NameError: undefined local variable or method `package_json'
  for #<Rails::Generators::AppGenerator...

Looks like it's a missing update from https://github.com/stimulusreflex/stimulus_reflex/pull/655

Why should this be added

Setup raises errors at the Yarn step

Checklist

netlify[bot] commented 12 months ago

Deploy Preview for stimulusreflex ready!

Name Link
Latest commit 34a75d2aa72b3b4eb993d9f2d42acb29af130ec5
Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/6563bfe502b5f80008b868c3
Deploy Preview https://deploy-preview-676--stimulusreflex.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

marcoroth commented 12 months ago

Thank you @mattboldt, let me take a look to make sure this properly works now!