search

stimulusreflex / stimulus_reflex

Build reactive applications with the Rails tooling you already know and love.
https://docs.stimulusreflex.com
MIT License
2.29k stars 174 forks source link

Explicitly require `ostruct` for `StimulusReflex::Dataset` #697

Closed marcoroth closed 7 months ago

marcoroth commented 7 months ago

Type of PR

Bug Fix

Description

From #695:

Rubocop v1.63.0 updates json to v2.7.2. json v2.7.2 https://github.com/flori/json/pull/565. StimulusReflex relies on OpenStruct in both the Dataset and the Element models. Attempting to run rails, ie a rails console, results in the error

Fixes #695

Why should this be added

Makes applications and CI run again.

We should think about migrating off of OpenStruct, but this PR should make it work for now as a work-around.

Checklist

netlify[bot] commented 7 months ago

Deploy Preview for stimulusreflex ready!

Name Link
Latest commit 9959149866440da5eea916247a9da1cea2094378
Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/662c19d714e7df0008d8a2da
Deploy Preview https://deploy-preview-697--stimulusreflex.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.