Closed marcoroth closed 6 months ago
Name | Link |
---|---|
Latest commit | 388934cad35ac8db7186b4488ec39a7d337c4121 |
Latest deploy log | https://app.netlify.com/sites/stimulusreflex/deploys/6633fa5d7b0731000825d7cd |
Deploy Preview | https://deploy-preview-699--stimulusreflex.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Type of PR
Enhancement
Description
This pull request isolates the methods defined
lib/stimulus_reflex/installer.rb
into aStimulusReflex::Installer
constant so they don't pollute the global namespace if the file is required.CableReady got a similar PR: https://github.com/stimulusreflex/cable_ready/pull/295
Why should this be added
Exposing all the methods from the installer in the global namespace could lead to issues down the road. Methods like
options
are likely to be overridden.Checklist