search

stimulusreflex / stimulus_reflex

Build reactive applications with the Rails tooling you already know and love.
https://docs.stimulusreflex.com
MIT License
2.29k stars 174 forks source link

Add Thor require for `StimulusReflex::Installer` #705

Closed juna-nb closed 6 months ago

juna-nb commented 6 months ago

Description

Rake tasks were failing in projects because the required Thor dependency was not always required, depending on the way it was called.

The fix also needed to explicitly require the thor gem in the installer file that used it as a mixin.

Fixes https://github.com/stimulusreflex/stimulus_reflex/issues/701

Why should this be added

Rake tasks in Rails applications were no longer working with the latest version of this Gem.

Checklist

netlify[bot] commented 6 months ago

Deploy Preview for stimulusreflex failed.

Name Link
Latest commit 2c05712c1de72281199c61f7fbf2530e1e5f9baa
Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/6650baf066f42e0008aa2d92
juna-nb commented 6 months ago

Just to note this change actually broke my app for some reason so this PR obviously still needs work. I'm not sure why it broke yet and this still blocks my deploys.