search

stinb / UnderstandForVSCode

VS Code extension for Understand
https://www.scitools.com
MIT License
1 stars 0 forks source link

Errors are only cleared if background checks are enabled #19

Closed RobbyCBennett closed 6 months ago

RobbyCBennett commented 6 months ago

Replicate:

  1. Disable background checks
  2. Find an error-free file
  3. Add a syntax error
  4. Analyze
  5. Fix the syntax error
  6. Analyze

image

I always use background checks, so I haven't noticed this until now.

RobbyCBennett commented 6 months ago

This is happening with parseAll, parseChanged, and parseFiles. For some reason, old errors remain with the IssueManager.

RobbyCBennett commented 6 months ago

@hackhaslam do you know why I still see old errors with the IssueManager when background CodeChecks are disabled? I only see it in userver and not Understand, so I guess I'm doing something wrong.

hackhaslam commented 6 months ago

It's probably fixed by stinb/sti@facd01e0cd211dcfa51b9f83ac13b65eb7a26932 that I just checked in. Those calls are required during the parse to be able to create and clear error/warning issues.

RobbyCBennett commented 6 months ago

Yes, that fixed it. Thank you. I didn't know that I had to do that.