Closed ogreen closed 8 years ago
Thanks, that looks good. Please remove commented-out code (keeping a copy for yourself of course) and squash everything into one commit.
@ogreen we're in the process of patching up dev in #181. When this is merged, all the commits at the beginning of your pull request (that aren't yours) can disappear, but you'll need to rebase against dev and then 'push -f'. @ehein6 will talk you through it. Please don't squash yet if you haven't already. Thanks!
@davidediger , @ehein6 - I had already squashed the commits. Please keep me posted on what needs to be done.
@ogreen Ok, #181 has been merged. Go ahead and rebase against dev, then push up your commit. That should fix the travis build, and assuming that passes this will be ready to merge.
@ogreen Squash one more time and we're good to go.
@ehein6 , squashed. Btw, this is real sqaush: https://www.youtube.com/watch?v=aIZQMQAl44I
@davidediger This is ready to merge.
This looks almost ready to merge, one more fix.
The standalone algorithm executables in
src/standalone
have been removed. Please removesrc/standalone/streaming_connected_components_hipc/main.c
You should instead create a client app that connects to the stinger server, and put the code in
src/clients/algorithms
. Take a look at betweenness.c as an example.