search

stirante / RuneChanger

RuneChanger is an app that improves and speeds up the use of LoL client.
https://runechanger.stirante.com/
GNU General Public License v3.0
86 stars 14 forks source link

[Bug] Overlay position error #41

Closed victor141516 closed 4 years ago

victor141516 commented 4 years ago

Describe the bug The overlay position is far away from the LCU window.

To Reproduce I'm using a 4k monitor with windows scaling set to 150%. If I change the scaling to 100% and restart RuneChanger, then it's in the correct position.

I think it's caused by how the size of the window is returned by the getHeight function.

Expected behavior The RuneChanger overlay should be over/next to the LCU window.

Screenshots image

(please complete the following information):

stirante commented 4 years ago

I tried to fix it in https://github.com/stirante/RuneChanger/commit/6cc78dbb087581e2bfe681969fc630378f06063c

I also pushed changes to experimental channel, so you can check, if they're working.

victor141516 commented 4 years ago

I works perfectly now 👍 Thank you!