search

stirante / RuneChanger

RuneChanger is an app that improves and speeds up the use of LoL client.
https://runechanger.stirante.com/
GNU General Public License v3.0
86 stars 14 forks source link

[Bug] RuneChanger always shows "not connected!" even when League is running. #49

Closed mrhappyasthma closed 4 years ago

mrhappyasthma commented 4 years ago

I just unzip the program, ran open.bat. The program launches but never connects to the League client.

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.75. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

stirante commented 4 years ago

Could you check "Run as admin" in settings and try again? If you don't see this option, you might need to enable experimental channel.

mrhappyasthma commented 4 years ago

I did need to enable experimental channel before I could set run as admin.

But even after restarting and allowing as admin, I still see "not connected!".

I'm running on Windows 7, if that matters.

stirante commented 4 years ago

I pushed quick update to experimental channel. After updating, click CTRL + L. This will generate log, which should help me to find cause of the bug (this log may contain list of all running processes, so If you don't want to paste it here, you can send me directly at discord or mail me at brzozowski.s.piotr@gmail.com)

mrhappyasthma commented 4 years ago 
Created at Thursday, July 2, 2020 at 11:28:14 AM Pacific Daylight Time
java.io.IOException: Cannot run program "WMIC": CreateProcess error=2, The system cannot find the file specified
    at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1128)
    at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1071)
    at java.base/java.lang.Runtime.exec(Runtime.java:589)
    at java.base/java.lang.Runtime.exec(Runtime.java:413)
    at java.base/java.lang.Runtime.exec(Runtime.java:310)
    at com.stirante.lolclient.ClientApi.generateDebugLog(ClientApi.java:710)
    at com.stirante.runechanger.gui.Settings$2.doInBackground(Settings.java:238)
    at com.stirante.runechanger.gui.Settings$2.doInBackground(Settings.java:235)
    at com.stirante.runechanger.util.AsyncTask.lambda$execute$2(AsyncTask.java:12)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:835)
Caused by: java.io.IOException: CreateProcess error=2, The system cannot find the file specified
    at java.base/java.lang.ProcessImpl.create(Native Method)
    at java.base/java.lang.ProcessImpl.<init>(ProcessImpl.java:420)
    at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:151)
    at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1107)
    ... 13 more
stirante commented 4 years ago

Looks like you don't have wmic, which is weird. It is deprecated, but I still have it on windows 10. Do you have powershell on windows 7? I could write a new implementation of checking for the LCU process If that's the case.

mrhappyasthma commented 4 years ago

I did some debugging and was able to resolve this.

I needed to add %SystemRoot%\System32\Wbem to my Path environment variable. Then it was able to find wmic.