stirante / RuneChanger

RuneChanger is an app that improves and speeds up the use of LoL client.
https://runechanger.stirante.com/
GNU General Public License v3.0
86 stars 14 forks source link

[Bug] Exception occurred while downloading asset #67

Closed i1u5 closed 3 years ago

i1u5 commented 3 years ago

Describe the bug The client fails to fetch assets from cdn.communitydragon.org

To Reproduce Steps to reproduce the behavior:

  1. Run fresh install right after a new patch
  2. Client will attempt to fetch assets
  3. An error will show due to community dragon not being up to date, manually checking the link shows this: {"statusCode":404,"error":"Not Found","message":"Patch '11.6' does not exist"}

Expected behavior Client should fetch current assets properly and have previous patch version as a fallback

Screenshots image

(please complete the following information):

Additional context The "solution" provided in expected behavior is just an idea, it could maybe be resolved in a better way, this is also not really a "bug", just an unhandled case of when the API is not up to date yet.

stirante commented 3 years ago

We actually have implemented fallbacks, but it seems I forgot to do this for assets, will fix it. Thanks!

stirante commented 3 years ago

Fixed https://github.com/stirante/RuneChanger/commit/f8e42d8b46a6de725de4e6b021808e012b1ea902