stirante / lol-client-java-api

Simple library which provides access to internal League of Legends Client API.
GNU General Public License v3.0
67 stars 14 forks source link

Preliminary support for lockfile resolving for clients running macOS #33

Closed szabolcs-dekany closed 1 year ago

szabolcs-dekany commented 1 year ago

Hey! 👋

I have not seen any guides here about the format of PRs. Let me know if I missed something.

Brief

This PR add preliminary support for LoL clients running macOS. The implementation is similar to the PSProcessWatcher, however due to some macOS quirkiness, some adjustments were made to accommodate proper implementation.

⚠️ Most likely a breaking change with future versions:

I have noticed while testing the process watcher, that when I started listing the skins available on my account, I started receiving purchaseDate values in the response JSONs larger and Long.MAX_VALUE so I switched to using BigInteger. Not sure if there is a more proper way to handle this or if this issue even came up with other users of the library.

stirante commented 1 year ago

Thanks for the PR! LGTM

Regarding the Long to BigInteger change, I will modify the script, that generates all those classes so the issue won't come back later.