Open obed-vazquez opened 1 year ago
I'm requesting access to the repo so I can create a pull request with the proposed implementation.
remote: Permission to stirante/lol-client-java-api.git denied to obed-vazquez.
fatal: unable to access 'https://github.com/stirante/lol-client-java-api.git/': The requested URL returned error: 403
A PR would be welcome, but it doesn't require write access. Fork the repository to your account, clone that fork locally, make changes, commit them, push them and then on GitHub you can make a PR.
A good example of a PR is this one: https://github.com/stirante/lol-client-java-api/pull/33
Here is a much more in depth description of PRs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
I think I've found a bug in the library when trying to map some summoner spells into a Java object.
Steps to reproduce
/lol-champ-select/v1/session
endpoint like:Comments
Long
maximum supported value, on LolChampSelectLegacyChampSelectPlayerSelection#spell1Id and I assume it is the same case for the 2nd spell too.BigInteger
which will be my suggestion for a solution.