Long limit Hotfix

obed-vazquez commented 1 year ago

This solves #34 issue with the proposed solution: swapping the Long field with a BigInteger

Jackson supports automatic mapping to a BigInteger which solves the problem of the field being too short to be mapped.

Swapped LolChampSelectLegacyChampSelectPlayerSelection#spell1Id and spell2Id Long type by BigInteger.
Bumped pom.xml version.

This might impact the automatic generation of the class and will be overridden if the process is run in the future.
Only manual test was executed. No automatic Testing (UT) has been introduced, do we want this to be included in the testing packages?

Please let me know of any concerns, comments, or improvements to the PR. Thanks to @stirante for the help!

stirante commented 1 year ago

Thanks, LGTM!

stirante commented 1 year ago

It's already building and soon should be available on my nexus maven repository. https://jenkins.stirante.com/job/lol-client-java-api/56/

stirante / lol-client-java-api