Closed obed-vazquez closed 1 year ago
This solves #34 issue with the proposed solution: swapping the Long field with a BigInteger
Jackson supports automatic mapping to a BigInteger which solves the problem of the field being too short to be mapped.
LolChampSelectLegacyChampSelectPlayerSelection#spell1Id
spell2Id
Long
BigInteger
test
Please let me know of any concerns, comments, or improvements to the PR. Thanks to @stirante for the help!
Thanks, LGTM!
It's already building and soon should be available on my nexus maven repository. https://jenkins.stirante.com/job/lol-client-java-api/56/
Long limit Hotfix
This solves #34 issue with the proposed solution: swapping the Long field with a BigInteger
Impacts
Jackson supports automatic mapping to a BigInteger which solves the problem of the field being too short to be mapped.
LolChampSelectLegacyChampSelectPlayerSelection#spell1Id
andspell2Id
Long
type byBigInteger
.Reviewers please consider:
test
ing packages?Please let me know of any concerns, comments, or improvements to the PR. Thanks to @stirante for the help!