stisa / jupyternim

A Jupyter kernel for nim
https://stisa.space/jupyternim/
MIT License
163 stars 14 forks source link

zmq.dll problem #33

Open snowzone5 opened 2 years ago

snowzone5 commented 2 years ago

I hope this saves a people a lot of time on Windows

I'm very new to nim, but not that new to VScode or Jupyter Notebooks.

nimble install jupyternim -y got me about 99.99% of the way.

The problem was that zmq.dll couldn't be found. Digging in I found the zmq.dll wasn't compiled:

Installing zmq@>= 1.2.1 & < 1.3.0
Downloading https://github.com/nim-lang/nim-zmq using git
  Verifying dependencies for zmq@1.2.1
 Installing zmq@1.2.1
   Success: zmq installed successfully.

Yeah, no.

I looked for a zmq.dll to download, found https://www.dll-files.com/libzmq.dll.html, but that was the 64bit version.

Found https://www.dll4free.com/libzmq.dll.html, scanned it for bad stuff, renamed it to zmq.dll and put it in the same folder as jupyternim.exe

Now it works in Jupyter Notebooks (Ananaconda version, and VScode)

stisa commented 2 years ago

Hey! Thanks for the report. Yeah, the nim-zmq package doesn't compile zmq, it's just to interface with the dll. Usually if you already have a jupyter installation, you should have that in path, otherwise you need to add it yourself. I mention it in the readme, but I'll see if I can find a good source for windows and link to it there to make this clearer. There should be some error like here: https://github.com/stisa/jupyternim/blob/400ec5d7bb7618826f084b1a92a84deb3abfa72d/src/jupyternim.nim#L77 did you have that? Did it just crash?

Glad you got it sorted!

snowzone5 commented 2 years ago

The only error was: could not load: (lib|)zmq.dll

No crashing though.

Could be I missed that part of the readme :)

This was the first package nim package I've installled that didn't work.

I have two Jupyter installs, one that comes with Anaconda Python, and the other is an extension for VSCode, neither one of them installed the zmq.dll

The second link I posted has the version that worked, I just thought I would help out anyone else who ran into the same issue. :)

stisa commented 2 years ago

Sorry, missed the notification. Interesting, I also have one jupyter install from miniconda and one from pip, both had the dll. Maybe yours didn't get added to path, so nim-zmq can't find them. I'll see if I can find a more reliable way to check it at installation time and also improve the error message. Thanks for reporting this!