search

stitchesjs / stitches

[Not Actively Maintained] CSS-in-JS with near-zero runtime, SSR, multi-variant support, and a best-in-class developer experience.
https://stitches.dev
MIT License
7.75k stars 253 forks source link

Format code with Prettier #992

Closed lesha1201 closed 2 years ago

lesha1201 commented 2 years ago

I noticed that some code wasn't formatted. I thought to run an existing script to format all the code but haven't found it so I added it to the root package.json:

image

I also changed a print width to 80 to increase readability. Previous value 240 were producing not very readable code in some places.

ESLint doesn't pass now because it's not configured. We should add configuration for ESLint which uses eslint-config-prettier.

I would check the format in CI but I haven't found a workflow for linting so I omitted it for now. I think we should create a workflow that lints and checks the format.

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a64d026f0dbd970760f577e9f20d78ed6ab54817:

Sandbox Source
Stitches CI: CRA Configuration
Stitches CI: Next.js Configuration
hadihallak commented 2 years ago

Hey @lesha1201 Thanks for working on this. the codebase indeed needs some prettier love but since this PR creates such a huge diff, I've created an issue to track it and include it as part of the next milestone.

For now, I'm gonna close this issue.

Again, Thank you so much for contributing to Stitches