Feature/universal mobile readiness

stitchfix / stitchfix.github.io

15 stars 4 forks source link

Feature/universal mobile readiness #19

Closed yorthehunter closed 10 years ago

yorthehunter commented 10 years ago

This does a bunch of mobile and tablet breakpoint optimizations for the layout.

This also fixes the scrollTo so it scrolls to the correct place for each heading.

If you take the time to look at the diff, you'll see some crazy-person markup adjustments, css cleanup, and other abstractions.

jonathandean commented 10 years ago

if it's good for you it's good for me. ship it!

yorthehunter commented 10 years ago

Some last bits:

Added a logo in the mobile version of the nav (where is user is most likely to get "lost")
Tested in Firefox, Chrome, Opera, Safari, Chrome (win), Safari (iphone), Chrome (iphone), Chrome (ipad)
And by "tested" I mean "ran through as quickly as possible looking for anything egregious"

yorthehunter commented 10 years ago

If anyone wants to pull out their Nokia HorseShit™ or visit us on Internet Explorer, then it's at their own risk (and we can write them off as candidates, probably)

jonathandean commented 10 years ago

Haha I'm so glad these comments are public. We'll get so many new candidates from this.

On Tuesday, August 12, 2014, Brian Cleveland notifications@github.com wrote:

If anyone wants to pull out their Nokia HorseShit™ or visit us on Internet Explorer, then it's at their own risk (and we can write them off as candidates, probably)

— Reply to this email directly or view it on GitHub https://github.com/stitchfix/stitchfix.github.io/pull/19#issuecomment-51982715 .

Jon Dean Principal Engineer _Stitch Fix | _your partner in personal style

jon@stitchfix.com 412-596-8348 (Eastern Time)