search

stitchfix / stitchfix.github.io

15 stars 4 forks source link

fix arrow on tech blog #25

Closed jonathandean closed 10 years ago

jonathandean commented 10 years ago

quick hack fix just removes the arrows falling down. @yorthehunter know how to really fix?

screen shot 2014-08-14 at 11 35 20 am

yorthehunter commented 10 years ago

WTH, I don't even know what causes that :{

But it makes me want to look into it. Those button widths wrap the content, so it's weird that it would break text like that.

ndp commented 10 years ago

A nbsp; or   didn't fix it? Anyway, our brand guidelines say that buttons don't need the raquo, so this is good.

From my wp days, I suspect it's measuring the text based on the metrics of the font specified, and then at some later point it discovers that it doesn't have the glyph for the raquo, so then it grabs one from another font, which has slightly different metrics. I have seen this: it doesn't have the font loaded, so it measures based on the substitute font. It's loading the fonts asynchronously, so when the right font eventually loads the fonts and goes about drawing it with different metrics. Either one is theoretically a browser bug.

jonathandean commented 10 years ago

Good thoughts, @ndp. Either way I don't love it in the button anyway. Do we need the button at all given the link in the nav?

Jon Dean Principal Engineer _Stitch Fix | _your partner in personal style

technology.stitchfix.com http://technology.stitchfix.com

jon@stitchfix.com 412-596-8348 (Eastern Time)

ndp commented 10 years ago

I think the button follows nicely the narrative of the page, so I'd keep it.

yorthehunter commented 10 years ago

@ndp puts it nicely. Thanks for the explanation!

jonathandean commented 10 years ago

Yep makes sense

Jon Dean Principal Engineer _Stitch Fix | _your partner in personal style

technology.stitchfix.com http://technology.stitchfix.com

jon@stitchfix.com 412-596-8348 (Eastern Time)