stitchfix / stitchfix.github.io

15 stars 4 forks source link

Chore/fix the plugin gh pages problem #29

Closed yorthehunter closed 10 years ago

yorthehunter commented 10 years ago

Problem:

The gh-pages site would not build after merging in the asset pipeline branch

Why?

gh-pages is a github static web host managed directly within a github repository. Jekyll is a github-friendly static site (blog) generator. gh-pages and our jekyll blog run—by necessity—in something called safe mode Pushing to the repo called stitchfix.github.io tells github to automatically create the gh-pages content from the master branch. It's a nice github feature, easy to work with across teams, and makes us look hip.

However, safe mode does not allow for unapproved Jekyll plugins, therefore we could not make use of the auto-generation benefit of gh-pages.

Solution(s):

Typically, you could do many things to get a deploy (e.g. use a framework like octopress, build locally and deploy the generated files, automate with a rake command, etc) but the sheer simplicity of "merge to master" is pretty awesome.

The solution, for now, is to roll back some of the changes and make the master branch compatible with safe mode gh-pages deployment. That's what this branch aims to do.

jonathandean commented 10 years ago

thanks for fixing!

yorthehunter commented 10 years ago

and for breaking, yeah? Actually it was a solid learning experience and we still have the directions in case we ever wanted to move the blog off of gh-pages.

jonathandean commented 10 years ago

you learn the most by failing first!